nmusgrave marked 2 inline comments as done. ================ Comment at: lib/CodeGen/CGClass.cpp:1652 @@ +1651,3 @@ + + static void Poison(CodeGenFunction &CGF, llvm::Value *OffsetPtr, + CharUnits::QuantityType PoisonSize); ---------------- eugenis wrote: > If it's a global function, it should have a more descriptive name, like > EmitSanitizerDtorCallback. > OffsetPtr => just Ptr > And move the body of the function to this line to avoid unnecessary > redeclaration. It's inside of a namespace- is it still global?
http://reviews.llvm.org/D12712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
