rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm, thanks! ================ Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN5test93barD2Ev + // CHECK4: call void @_ZN6test103barD2Ev bar ptr; ---------------- Isn't this still in the test9 namespace? Shouldn't this change be reverted? ================ Comment at: test/CodeGenCXX/microsoft-abi-structors.cpp:411 @@ -410,3 @@ - -// FIXME: This should be x86_thiscallcc. MSVC ignores explicit CCs on structors. -// CHECK: define %"struct.test1::B"* @"\01??0B@test1@@QAA@PAF@Z" ---------------- Hah, looks like we encountered this long ago and didn't go back for it. :) http://reviews.llvm.org/D12402 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
