krememek added a subscriber: krememek. krememek added a comment. This looks fine, but I'm not a fan of the actual name chosen here. It's not very clear what it means by just looking at the name, and as we grow the number of configuration options that will become more important.
A few suggestions: - `min-block-size-treat-functions-as-large` - `min-cfg-size-treat-functions-as-large` (since "blocks" is a bit ambiguous) - `min-cfg-size-categorize-functions-as-large` Unrelated to this patch, several of our other options suffer from my same concerns, e.g.: `max-times-inline-large`, `max-inclinable-size`, but changing those are not the focus of this patch. Other than the name, this looks good to me. Whatever name we choose, I think the method name should also be appropriately named, e.g.: - `getMinCFGSizeToTreatFunctionsAsLarge()` http://reviews.llvm.org/D12406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
