EricWF added inline comments. ================ Comment at: utils/gen_link_script/gen_link_script.py:1 @@ +1,2 @@ +#!/usr/bin/env python +import os ---------------- jroelofs wrote: > Do you foresee these linker scripts being significantly more complicated for > other platforms? ISTM that it would be much simpler to have CMake generate > these directly. The linker scripts will get no more complicated. The will always just be `INPUT(libc++.so.x.x -l<abilib>)`. However generating these in CMake is a pain. I've tried before and I promise the python approach is a lot cleaner.
The main reason is that most CMake functions such as `FILE(...)` and `CONFIG_FILE(...)` are run at CMake configuration time and they don't allow generator expressions in them. I also don't know how to read the value of a symlink using CMake which is needed to generate the linker script. If you really want me to rewrite this is CMake I will, but I promise that you probably don't. http://reviews.llvm.org/D12508 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
