danielmarjamaki added a subscriber: danielmarjamaki.
danielmarjamaki added a comment.
Overall.. LGTM
================
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:78
@@ -78,2 +77,3 @@
+ llvm_unreachable("Unexpected enumeration.");
return "";
}
----------------
After llvm_unreachable there is often not a return.
http://reviews.llvm.org/D12619
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
