klimek added inline comments. ================ Comment at: test/clang-tidy/modernize-loop-convert-basic.cpp:448 @@ +447,3 @@ + ret = it; + } +} ---------------- angelgarcia wrote: > klimek wrote: > > This test seems to be missing the it.insert(0) case that was removed from > > the "unsupported" comment, if I'm not missing something. > It was in the test 'modernize-loop-convert-negative.cpp'. I moved these ones > there as well. Why is that case removed from the unsupported list then?
================ Comment at: test/clang-tidy/modernize-loop-convert-basic.cpp:519-521 @@ -518,5 +518,5 @@ unsigned size() const; - unsigned begin() const; - unsigned end() const; + unsigned* begin() const; + unsigned* end() const; }; ---------------- That makes sense. http://reviews.llvm.org/D12530 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
