piotrdz added a comment. @alexfh: Thanks for reviewing my code. The amount of comments makes it pretty clear that it's my first contribution here :-). But no worries, I'll address each issue.
> This check seems pretty similar to the check implemented in > clang-tidy/readability/NamedParameterCheck.h/.cpp. Having both doesn't make > much sense, so one of them will have to die (probably, the other one). > Nothing should be done to this effect now, we'll figure out after this check > is polished enough. Ah, I only now noticed it. It's kind of "opposite" to my check - it checks for unnamed parameters that should have their names in comments, while my check completely ignores unnamed parameters and checks the named ones. Anyways, I agree, that it would be good to merge them and have one check do both things. http://reviews.llvm.org/D12462 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
