andreybokhanko added inline comments. ================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323 @@ -2323,1 +2322,3 @@ + "definition with same mangled name as another definition">, + InGroup<DuplicateMangledNames>; def err_cyclic_alias : Error< ---------------- rjmccall wrote: > I'm sorry to bring this up so late in the process, but is there a good reason > for this to be a warning and not an error? No good reasons at all -- I thought you want this to be a warning, but looks like I misinterpreted you.
Do you want me to make this an error? (If yes, apart of changing warn_duplicate_mangled_name to err_duplicate_mangled_name everywhere, I will have to change the test -- let me know whatever you want to review these changes or not really interested and your "go ahead and fix it and then commit" still holds true) Andrey http://reviews.llvm.org/D11297 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
