hfinkel added a comment.

I also like this intrinsic approach better than the type attribute.

The fact that it does not work with builtin vector types, however, is quite 
unfortunate. Plus, I don't understand why you're implementing another place in 
CodeGen that generates IR to load and store scalar values. Can't you enhance 
EmitLoadOfScalar/EmitStoreOfScalar and then use those functions? If nothing 
else, you're already missing setting of TBAA metadata and other things that 
these functions do.


http://reviews.llvm.org/D12313



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to