Author: tnowicki
Date: Thu Aug 27 13:58:34 2015
New Revision: 246189
URL: http://llvm.org/viewvc/llvm-project?rev=246189&view=rev
Log:
Improve options printed on vectorization analysis diagnostics.
The LLVM patch changes the analysis diagnostics produced when loops with
floating-point recurrences or memory operations are identified. The new messages
say "cannot prove it is safe to reorder * operations; allow reordering by
specifying #pragma clang loop vectorize(enable)". Depending on the type of
diagnostic the message will include additional options such as ffast-math or
__restrict__.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td
cfe/trunk/test/Frontend/optimization-remark-options.c
Modified: cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td?rev=246189&r1=246188&r2=246189&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td Thu Aug 27
13:58:34 2015
@@ -46,13 +46,14 @@ def remark_fe_backend_optimization_remar
def remark_fe_backend_optimization_remark_analysis : Remark<"%0">, BackendInfo,
InGroup<BackendOptimizationRemarkAnalysis>;
def remark_fe_backend_optimization_remark_analysis_fpcommute : Remark<"%0; "
- "allow commutativity by specifying '#pragma clang loop vectorize(enable)' "
- "before the loop or by providing the compiler option '-ffast-math'">,
+ "allow reordering by specifying '#pragma clang loop vectorize(enable)' "
+ "before the loop or by providing the compiler option '-ffast-math'.">,
BackendInfo, InGroup<BackendOptimizationRemarkAnalysis>;
def remark_fe_backend_optimization_remark_analysis_aliasing : Remark<"%0; "
- "avoid runtime pointer checking when you know the arrays will always be "
- "independent by specifying '#pragma clang loop vectorize(assume_safety)' "
- "before the loop or by specifying 'restrict' on the array arguments. "
+ "allow reordering by specifying '#pragma clang loop vectorize(enable)' "
+ "before the loop. If the arrays will always be independent specify "
+ "'#pragma clang loop vectorize(assume_safety)' before the loop or provide "
+ "the '__restrict__' qualifier with the independent array arguments. "
"Erroneous results will occur if these options are incorrectly applied!">,
BackendInfo, InGroup<BackendOptimizationRemarkAnalysis>;
def warn_fe_backend_optimization_failure : Warning<"%0">, BackendInfo,
Modified: cfe/trunk/test/Frontend/optimization-remark-options.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/optimization-remark-options.c?rev=246189&r1=246188&r2=246189&view=diff
==============================================================================
--- cfe/trunk/test/Frontend/optimization-remark-options.c (original)
+++ cfe/trunk/test/Frontend/optimization-remark-options.c Thu Aug 27 13:58:34
2015
@@ -1,6 +1,6 @@
// RUN: %clang -O1 -fvectorize -target x86_64-unknown-unknown
-Rpass-analysis=loop-vectorize -emit-llvm -S %s -o - 2>&1 | FileCheck %s
-// CHECK: {{.*}}:9:11: remark: loop not vectorized: vectorization requires
changes in the order of operations, however IEEE 754 floating-point operations
are not commutative; allow commutativity by specifying '#pragma clang loop
vectorize(enable)' before the loop or by providing the compiler option
'-ffast-math'
+// CHECK: {{.*}}:9:11: remark: loop not vectorized: cannot prove it is safe to
reorder floating-point operations; allow reordering by specifying '#pragma
clang loop vectorize(enable)' before the loop or by providing the compiler
option '-ffast-math'.
double foo(int N) {
double v = 0.0;
@@ -11,7 +11,7 @@ double foo(int N) {
return v;
}
-// CHECK: {{.*}}:18:13: remark: loop not vectorized: cannot prove pointers
refer to independent arrays in memory. The loop requires 9 runtime independence
checks to vectorize the loop, but that would exceed the limit of 8 checks;
avoid runtime pointer checking when you know the arrays will always be
independent by specifying '#pragma clang loop vectorize(assume_safety)' before
the loop or by specifying 'restrict' on the array arguments. Erroneous results
will occur if these options are incorrectly applied!
+// CHECK: {{.*}}:18:13: remark: loop not vectorized: cannot prove it is safe
to reorder memory operations; allow reordering by specifying '#pragma clang
loop vectorize(enable)' before the loop. If the arrays will always be
independent specify '#pragma clang loop vectorize(assume_safety)' before the
loop or provide the '__restrict__' qualifier with the independent array
arguments. Erroneous results will occur if these options are incorrectly
applied!
void foo2(int *dw, int *uw, int *A, int *B, int *C, int *D, int N) {
for (int i = 0; i < N; i++) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
