krememek added a comment. One thing about the tests passing: that's great, but that's obviously insufficient. We probably have fewer tests showing that the analyzer can't handle something than tests that show it does handle something.
When a patch like this lands, which expands the analysis scope of the core analyzer, a few things are worth measuring: (1) The impacted analysis time on a typical project. (2) The impacted memory usage of the analyzer on a typical project. (3) Increased analysis coverage. Are we covering more statements in practice? Etc. Since that is the motivation of this patch, it would be good to benchmark it on some real code. We should, as a community, start keeping track of such things for a few projects so we know whether or not experiments like these are objectively a real win. http://reviews.llvm.org/D12358 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
