xazax.hun added inline comments. ================ Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:237 @@ +236,3 @@ + return PreObjCMessageCheckers; + break; + case ObjCMessageVisitKind::Post: ---------------- nit: remove the break after the return.
================ Comment at: lib/StaticAnalyzer/Core/ExprEngineObjC.cpp:197 @@ +196,3 @@ + // Generate a transition to non-Nil state, dropping any potential + // non-nil flow. + if (notNilState != State) { ---------------- Aren't we dropping the nil flow here instead of the non-nil? If that's the case, the comment should reflect that. http://reviews.llvm.org/D12123 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits