Author: chapuni
Date: Thu Aug 20 10:04:39 2015
New Revision: 245566
URL: http://llvm.org/viewvc/llvm-project?rev=245566&view=rev
Log:
Tweak clang-tools-extra/test/clang-tidy/file-filter.cpp to pass on win32.
FIXME: "-I %S/Inputs/file-filter/system/.." must be redundant.
On Win32, file-filter/system\system-header1.h precedes file-filter\header*.h
due to code order between '/' and '\\'.
We should remove such a tweak to introduce the *right* path canonicalization.
Posix:
file-filter/header*.h
file-filter/system/system-header1.h
Win32:
file-filter/system\system-header1.h
file-filter\header*.h
Win32, tweaked:
file-filter/system/..\header*.h
file-filter/system\system-header1.h
It had been disabled since r220837.
Modified:
clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp
Modified: clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp?rev=245566&r1=245565&r2=245566&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/file-filter.cpp Thu Aug 20 10:04:39
2015
@@ -1,7 +1,10 @@
// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter=''
%s -- -I %S/Inputs/file-filter -isystem %S/Inputs/file-filter/system 2>&1 |
FileCheck %s
// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='.*' %s -- -I %S/Inputs/file-filter -isystem
%S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK2 %s
// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='header2\.h' %s -- -I %S/Inputs/file-filter -isystem
%S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK3 %s
-// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='.*' -system-headers %s -- -I %S/Inputs/file-filter -isystem
%S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK4 %s
+// FIXME: "-I %S/Inputs/file-filter/system/.." must be redundant.
+// On Win32, file-filter/system\system-header1.h precedes
+// file-filter\header*.h due to code order between '/' and '\\'.
+// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='.*' -system-headers %s -- -I %S/Inputs/file-filter/system/..
-isystem %S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK4 %s
#include "header1.h"
// CHECK-NOT: warning:
@@ -40,6 +43,3 @@ class A { A(int); };
// CHECK3: Use -header-filter=.* {{.*}}
// CHECK4-NOT: Suppressed {{.*}} warnings
// CHECK4-NOT: Use -header-filter=.* {{.*}}
-
-// FIXME: It doesn't pass on win32. Investigating.
-// REQUIRES: shell
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
