Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

[Richard Smith via cfe-commits]

rsmith added inline comments.

================
Comment at: include/clang/AST/ASTContext.h:180
@@ -179,3 +179,3 @@
   /// that appear in constant initializers to their evaluated values.
-  llvm::DenseMap<const MaterializeTemporaryExpr*, APValue>
+  std::map<const MaterializeTemporaryExpr *, APValue>
     MaterializedTemporaryValues;
----------------
I would prefer a `DenseMap<const MaterializedTemporaryExpr*, APValue*>`, with 
`APValue`s allocated by the `ASTContext`'s `BumpPtrAllocator`.


http://reviews.llvm.org/D11629



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits