Author: djasper
Date: Mon Aug 10 10:45:46 2015
New Revision: 244454
URL: http://llvm.org/viewvc/llvm-project?rev=244454&view=rev
Log:
misc-unused-parameters: Don't touch K&R style functions.
We couldn't calculate the removal ranges properly at this point.
Added:
clang-tools-extra/trunk/test/clang-tidy/misc-unused-parameters.c
Modified:
clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp?rev=244454&r1=244453&r2=244454&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp Mon Aug
10 10:45:46 2015
@@ -97,7 +97,8 @@ void UnusedParametersCheck::warnOnUnused
void UnusedParametersCheck::check(const MatchFinder::MatchResult &Result) {
const auto *Function = Result.Nodes.getNodeAs<FunctionDecl>("function");
- if (!Function->doesThisDeclarationHaveABody())
+ if (!Function->doesThisDeclarationHaveABody() ||
+ !Function->hasWrittenPrototype())
return;
for (unsigned i = 0, e = Function->getNumParams(); i != e; ++i) {
const auto *Param = Function->getParamDecl(i);
Added: clang-tools-extra/trunk/test/clang-tidy/misc-unused-parameters.c
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-unused-parameters.c?rev=244454&view=auto
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-unused-parameters.c (added)
+++ clang-tools-extra/trunk/test/clang-tidy/misc-unused-parameters.c Mon Aug 10
10:45:46 2015
@@ -0,0 +1,13 @@
+// RUN: $(dirname %s)/check_clang_tidy.sh %s misc-unused-parameters %t -- -xc
+// REQUIRES: shell
+
+// Basic removal
+// =============
+void a(int i) {}
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: parameter 'i' is unused
[misc-unused-parameters]
+// CHECK-FIXES: {{^}}void a(int /*i*/) {}{{$}}
+
+// Unchanged cases
+// ===============
+void h(i, c, d) int i; char *c, *d; {} // Don't mess with K&R style
+
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
