On 15/02/15 15:56, Toke Høiland-Jørgensen wrote:
Sebastian Moeller <moell...@gmx.de> writes:
I am not sure that this works as intended. The first thing
run.sh does is take down all running SQM instances:
Ah yes, seems I was a bit too trigger-happy there ;)
I was just about to explain the same, after testing it :). (I have more
interfaces coming up after pppoe-wan, so SQM stops immediately after
it's started)
Here's a version of run.sh that should also short-circuit the 'down'
part if called from hotplug.
Yep. that version works ok.
The alternative is, of course, to have logic in the hotplug script to
only call run.sh for interfaces that are enabled, but that would require
parsing /etc/config/sqm from there. My initial thought was that
short-circuiting the logic in run.sh was 'cleaner'; but I'm not entirely
sure about that... Thoughts?
-Toke
It's a small tweak, but maybe the argument to run.sh could be made explicit.
run.sh start $DEVICE # specific device
run.sh # all devices
Regards
Alan
_______________________________________________
Cerowrt-devel mailing list
Cerowrt-devel@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cerowrt-devel
