> On Sep 25, 2018, at 20:24, Ilya Dryomov <idryo...@gmail.com> wrote: > > On Tue, Sep 25, 2018 at 2:05 PM 刘 轩 <mr.liux...@outlook.com> wrote: >> >> Hi Ilya: >> >> I have some questions about the commit >> d84b37f9fa9b23a46af28d2e9430c87718b6b044 about the function >> handle_cap_export. In which case, issued! = cap->implemented may occur. >>
This warning can happen if client session becomes stale when mds exports/imports caps. The situation is difficult to handle. >> I encountered this kind of mistake in my cluster. Do you think this is >> probably BUG? >> >> ceph: limit rate of cap import/export error messages >> >> https://github.com/ceph/ceph-client/commit/d84b37f9fa9b23a46af28d2e9430c87718b6b044 >> >> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c >> index 7e09fa8ab0ed..f28efaecbb50 100644 >> --- a/fs/ceph/caps.c >> +++ b/fs/ceph/caps.c >> @@ -3438,7 +3438,14 @@ static void handle_cap_export(struct inode *inode, >> struct ceph_mds_caps *ex, >> */ >> >> issued = cap->issued; >> - WARN_ON(issued != cap->implemented); >> + if (issued != cap->implemented) >> + pr_err_ratelimited("handle_cap_export: issued != implemented: " >> + "ino (%llx.%llx) mds%d seq %d mseq %d " >> + "issued %s implemented %s\n", >> + ceph_vinop(inode), mds, cap->seq, cap->mseq, >> + ceph_cap_string(issued), >> + ceph_cap_string(cap->implemented)); >> + >> >> tcap = __get_cap_for_mds(ci, target); >> if (tcap) { > > Resending to ceph-users in plain text, adding Zheng. > > Thanks, > > Ilya _______________________________________________ ceph-users mailing list ceph-users@lists.ceph.com http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
