My initial reaction to this PR/backport was questioning why such a major
update would happen on a dot release of Luminous.  Your reaction to keeping
both dashboards viable goes to support that.  Should we really be
backporting features into a dot release that force people to change how
they use the software?  That seems more of the purpose of having new
releases.

I haven't really used either dashboard though.  Other than adding admin
functionality, does it remove any functionality of the previous dashboard?

On Wed, Aug 22, 2018 at 1:43 PM Ernesto Puerta <epuer...@redhat.com> wrote:

> Thanks for your feedback, Willem!
>
> > The old dashboard does not need any package fetch while
> > building/installing. Something that is not very handy when building
> > FreeBSD packages. And I haven't gotten around to determining how to >
> get around that.
>
> I thought that https://github.com/ceph/ceph/pull/22562 fixed make-dist
> issues on FreeBSD. Is that not working yet? Let us know if that's the
> case!
>
> > Suggest renaming it to simpledash or dashboard_v1 and keep it in the
> > tree.
>
> Unfortunately, keeping v1 is not as simple as moving the dashboard to
> a separate directory (unless we leave it hanging as dead code).
> Dashboard_v2 completely replaces dashboard_v1, and that also means
> unit test, QA suites, and references in common files (install-deps.sh,
> CMakeLists.txt, ceph.spec.in, debian/*, do_freebsd.sh, vstart.sh,
> etc.).
>
> My concern is that properly keeping both ones would go beyond a
> long-but-mostly-clean cherry-picking. It'd involve Luminous actively
> diverging from master, which might burden other backports with
> manual/creative conflict-solving.
>
> KR,
>
> Ernesto
>
> On Wed, Aug 22, 2018 at 12:43 PM Willem Jan Withagen <w...@digiware.nl>
> wrote:
> >
> > On 22/08/2018 12:16, Ernesto Puerta wrote:
> > > [sent both to ceph-devel and ceph-users lists, as it might be of
> > > interest for both audiences]
> > >
> > > Hi all,
> > >
> > > This e-mail is just to announce the WIP on backporting dashboard_v2
> > > (http://docs.ceph.com/docs/master/mgr/dashboard/) from master to
> > > Luminous release.
> > >
> > > The ultimate goal for this backport is to replace dashboard_v1 in
> > > Luminous and provide, **as much as possible**, (see note below) a
> > > level of functionality on a par with master's (i. e.: RBD and RGW
> > > management, HTTPS support, User Management, Role Based Access Control,
> > > Grafana integration, SSO, etc.).
> >
> > If done so, I would prefer to also keep the old "simple" Dashboard.
> > Reason for that is the ease of portability.
> >
> > The old dashboard does not need any package fetch while
> > building/installing. Something that is not very handy when building
> > FreeBSD packages. And I haven't gotten around to determining how to get
> > around that.
> >
> > Next to that: that dashboard is "simple". Something I really like, but
> > that is perhaps personal.
> >
> > Suggest renaming it to simpledash or dashboard_v1 and keep it in the
> tree.
> >
> > Thanx,
> > --WjW
> >
> _______________________________________________
> ceph-users mailing list
> ceph-users@lists.ceph.com
> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>
_______________________________________________
ceph-users mailing list
ceph-users@lists.ceph.com
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com

Reply via email to