On Tue, Dec 2, 2014 at 12:38 AM, Ken Dreyer <kdre...@redhat.com> wrote:
> On 11/28/14 7:04 AM, Haomai Wang wrote: > > Yeah, ceph source repo doesn't contain Kinetic header file and library > > souce, you need to install kinetic devel package separately. > > Hi Haomai, > > I'm wondering if we need AC_CHECK_HEADER([kinetic/kinetic.h], ...) in > configure.ac to double-check when the user specifies --with-kinetic? It > might help to avoid some user confusion if we can have ./configure bail > out early instead of continuing all the way through the build. > > Something like this? (completely untested) > > --- a/configure.ac > +++ b/configure.ac > @@ -557,7 +557,13 @@ AC_ARG_WITH([kinetic], > #AS_IF([test "x$with_kinetic" = "xyes"], > # [PKG_CHECK_MODULES([KINETIC], [kinetic_client], [], [true])]) > AS_IF([test "x$with_kinetic" = "xyes"], > - [AC_DEFINE([HAVE_KINETIC], [1], [Defined if you have > kinetic enable > + [AC_CHECK_HEADER([kinetic/kinetic.h], > + [AC_DEFINE( > + [HAVE_KINETIC], [1], [Defined if you have kinetic > enabled])], > + [AC_MSG_FAILURE( > + ["Can't find kinetic headers; please install them"]) > + )] > +]) > AM_CONDITIONAL(WITH_KINETIC, [ test "$with_kinetic" = "yes" ]) > Yeah, it's better. Anyone who help to add these? You can close https://github.com/ceph/ceph/pull/3046 and create a PR. I don't have a std-c++11 env to test it at all :-( > _______________________________________________ > ceph-users mailing list > ceph-users@lists.ceph.com > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com > -- Best Regards, Wheat
_______________________________________________ ceph-users mailing list ceph-users@lists.ceph.com http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
