Thanks for the response John.
We "spoke" on my PR for the log level set to DEBUG.
I also have a PR open https://github.com/ceph/cephadm-ansible/pull/339 .
I tested this one on my Ceph cluster.
The issue which caused me to was that when I ran the preflight
playbook it populated my /etc/yum.repos.d/ dir with a file called
ceph_stable_$basearch (notice the dollar sign in the file name). The
issue seems to be cosmetic since it still works, but still IMHO should
be fixed. Upon looking into the file it also adds the $ into the name
and description.
The bug is really simple.
It uses $basearch for the repo URL as it should, but it also uses the
same variable with the dollar sign for the file name, repo name and
description.
My fix is to simply add a "| trim('$')" to remove the $ from the
places where we don't want it.
To me it seemed like the simplest solution, although may be not the
most elegant.
We can't simply add the dollar sign to baseurl: "{{ _ceph_repo.baseurl
}}/{{ $item }}" since noarch is also a variable but it can't have a
'$'.
Since I was already fixing this, I fixed another cosmetic issue of the
repo url having two forward slashes (//).
Those come from the trailing slash in the variable as well as a slash in
"{{ _ceph_repo.baseurl }}/{{ item }}"
My first attempt was to remove the "/" from the line above but then I
realized that if someone left it out from the variable it would break
so I removed it from the variable but kept it in the code.
If you agree that this is a bug and not intended to be that way then
please take a look at my PR.
I'm fairly comfortable with Ansible but first time Forking a repo so
I'm sure I did it wrong so please let me know how to fix it and if I
can actually make this VERY small contribution to the Ceph codebase
that would be amazing.
Thanks!
Alex
_______________________________________________
ceph-users mailing list -- ceph-users@ceph.io
To unsubscribe send an email to ceph-users-le...@ceph.io
