On Thursday, April 10, 2025 10:42:50 PM Eastern Daylight Time Alex wrote: > I made a Pull Request for cephadm.log set DEBUG. > Not sure if I should merge it.
Please, no. Even if github allows you to (I think it won't) you should not merge your own PRs unless you are a component lead and it is an emergency (IMO - but I think many would agree). I have left a comment on what I assume is your pr: https://github.com/ceph/ ceph/pull/62789 PS. If you meant creating merge commits in your own PR branch, that is unsightly but harmless. If you meant what I think you meant - merge the PR into ceph main - that's what I object to. You need to follow the contribution process and get reviews, and have the PR get tested, before the component lead would possibly merge the changes into the main branch. _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-le...@ceph.io
