A Tuesday 07 October 2008 01:43:57, Pawel Veselov escreveu:
> On Mon, Oct 6, 2008 at 5:33 PM, Pedro Alves <[EMAIL PROTECTED]> wrote:
> > <Warning, quick 1-minute, not a full review.>
> >
> > On Tuesday 07 October 2008 00:49:05, Pawel Veselov wrote:
> >> +#define TRACING(level) ((WCETRACE_DEBUGGER_GET() & level) || \
> >
> > Can you rename TRACING into something else no so generic, please?
> > Sounds like asking for trouble down the line.
> >
> > __WCETRACE_P ?
> >
> > __WCETRACING ?
> >
> > (_P is a semi-standard suffix for predicate.)
>
> Sure, will do.
>
> >
> >> + (WCETRACEGET() & level))
> >> +#define WCETRACE(level, fmt...) do { \
> >> + if (TRACING(level)) { \
> >> + __WCETrace((level), fmt); \
> >
> > Missing ## __VA_ARGS__ ?
>
> Some trick I probably don't know about... I ran gcc -E, and checked
> that "fmt" expands to the format and the
> arguments thereafter... I googled this, and It seems that
>
> #define M(x...) { m(x); }
> is the same as
> #define M(x, ...) { m(x, ##__VA_ARGS__); }
Ah, I missed that. You version is fine.
>
> >
> >> + } } while(0)
> >> +
> >
> > --
> > Pedro Alves
> >
>
> Thanks,
> Pawel.
>
>
--
Pedro Alves
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
