On 1/31/21 10:19 AM, Chase via cdesktopenv-devel wrote: > Fedora and family don't install patch by default, so we need to > specifically test for it. Also, apparently distclean crashes when it > reaches the JP locale. >
I've applied these, though I had to make a change - in the future, please test with parallel builds when working in this tree. While a single core build worked, a multi-core build (make -j8, for example) failed. So - I disabled parallel builds for dtksh (/.NOTPARALLEL:/). But one benefit of autotools is the ability to do multi-core builds (where is make sense) which can really speed up things. For some modules, that is just never going to work - so I am not suggesting you need to figure out how to get dtksh building with parallel builds, but you should at least test it first, and add /.NOTPARALLEL:/ to a Makefile.am if needed to in order to build successfully. Another issue - when you change the hash for ksh93 - please make that a separate and independent commit, and only submit it when you are sure it will build on everything. Just a request for the future. The distclean issue is also fixed. We should not have entered the Japanese locale as something that can actually be built. It is selected by distclean whether or not it is actually buildable - it just assumed it was since it was mentioned in the localized SUBDIRS. So that is resolved too by simply disabling any support for the Japanese locale. Another issue I ran into that perhaps you could take a look at it, is with dtappbuilder. For some reason, whenever I do a 'make install' it always tries to rebuild dtbuilder. Not sure why, but that needs to be fixed too. I mention it to you as it was your patches that enabled it's building and I guess I never noticed it when applying/testing. > On a side note, I am still of the opinion that we should replace > tradcpp with sed wherever possible, it would be one less program that > we would have to maintain and build, and some tests I ran show that > sed is slightly faster. I could do the work to replace it if need be. > If there are actual problems, I'm listening. But so far it has worked perfectly and I have no interest in changing it. While sed can do substitution, how well does it work with the evaluation of conditionals? What exact problems are you having with it? There's a lot more going on there than simple /sed -e 's/XCOMM /# /g' /type stuff... Thanks! -jon > Thank you for your time, > -Chase > > > > > _______________________________________________ > cdesktopenv-devel mailing list > cdesktopenv-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel -- Jon Trulson "Entropy. It isn't what it used to be." -- Sheldon
_______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
