Thanks for fixing that up. I've had a lot of local issues building CDE lately, but that's my own environment. I figured I could do this and throw it over the fence and then either fix it later or someone else could pick it up. So, thank you.
On 08/25/2018 07:43 PM, Jon Trulson wrote: > Ok, committed to master with some fixes. > -jon > > On 08/25/2018 04:50 PM, Jon Trulson wrote: >> And I just found a similar problem with ‘CopyFileSysType() in >> sharedFuncs.c -- passing an int as the first arg to statfs(). Just FYI. >> -jon >> >> On 08/25/2018 04:49 PM, Jon Trulson wrote: >>> This one needs some more work - The issue is that in Trash.c, >>> CheckDeletePermission(), a call is made to a (stupidly named) >>> function called FileSysType(). This accepts an integer corresponding >>> to statbuf.st_dev >>> >>> However, FileSysType() calls statfs (with your changes) with this >>> argument as the first argument (which must be a char *path) - so we >>> get an integer to pointer conversion warning. >>> >>> In reality, CheckDeletePermission() is the only function that calls >>> this FileSysType(). >>> >>> CheckDeletePermission() can almost certainly be refactored to >>> eliminate this. For example, the code involved seems to be all about >>> detecting whether root can delete a file on an NFS mounted FS. >>> >>> I will work on this one locally, and improve it somewhat with follow >>> on patch(es) before merging to master. >>> >>> -jon >>> >>> On 08/21/2018 02:17 PM, David Cantrell wrote: >>>> On 08/21/2018 03:55 PM, David Cantrell wrote: >>>>> This is now a compile time failure on systems with glibc-2.28 as they >>>>> have removed ustat(2) from the library. The replacement for a >>>>> while has >>>>> been statfs(2), so this patch does that for dtfile which is the only >>>>> program I found that uses that. >>>>> >>>>> Also, this patch could be refactored or just have a different style. >>>>> Not sure what the project is aiming for here, but let me know if you >>>>> want things altered. >>>>> >>>>> Thanks, >>>>> >>>> >>>> Whoops, forgot to include sys/vfs.h in Trash.c. Here's revision 2 of >>>> the patch. >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> Check out the vibrant tech community on one of the world's most >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>>> >>>> >>>> >>>> _______________________________________________ >>>> cdesktopenv-devel mailing list >>>> cdesktopenv-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel >>>> >>> >> > -- David Cantrell <dcantr...@redhat.com> Red Hat, Inc. | Boston, MA | EST5EDT ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
