This one is wrong...

On 08/26/2018 08:57 AM, Chase via cdesktopenv-devel wrote:
-  for lib in $(/bin/ls) ./*.so.*
+  for lib in $(/bin/ls) -- *.so.*

That should be:

for lib in $(/bin/ls lib*.so.*)

With your change, it did dumb things like create symlinks "--" -> "--", "dtksh" -> "dtksh", and the like.

There was another problem with that file -- in a previous commit, you changed:

HandleOption $*

to

HandleOption "$*"

This is also wrong - it makes multiple arguments into a single argument for the HandleOption function. This means any options specified, unless it is only a single option, is unrecognized.

I have fixed both issues in a separate commit.

Take this shellcheck output with a grain of salt -- just blindly adding "" around arguments and variables without understanding exactly what is going on is definitely going to break things...


--
Jon Trulson

"Fire all weapons and open a hailing frequency for my victory yodle."

                              - Zapp Brannigan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to