This one I can't merge, for the same reason as the previous nsglms patch.
While I definitely want to do this kind of stuff, we can't simply remove
it since it will break for everyone else not on linux.
For these types of patches, we need to:
1) Don't delete the code (tcl in this case)
2) Just don't build it for Linux, and use the system version (modify the
relevant Imakefiles).
3) mention in the commit message what package needs to be installed - I
think in this case, it would need to be "tcl-dev". This would act as a
flag for me to be sure an update the wiki pages for the relevant OS so
users don't run into problems.
4) Once all of the platforms have been fixed to use their OS packages,
THEN we can remove the relevant code from CDE.
If I apply this patch now, it will then be broken for everyone else
except linux. So, unless you intend to fix all of those other OS's in
your patch, don't delete the code so that those OS's can continue to use
it until "fixed".
This is the same with the nsgmls patch you sent earlier.
-jon
On 08/19/2018 03:10 PM, Chase via cdesktopenv-devel wrote:
This patch uses the system's tcl, although I very much need someone to
put ifdefs in the Imakefile to give the location of the archive on bsd
and solaris based systems, as it only works on linux right now.
Thank you for your time,
-Chase
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
--
Jon Trulson
"Fire all weapons and open a hailing frequency for my victory yodle."
- Zapp Brannigan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
