Jon Trulson <j...@radscan.com> writes: > On 06/26/2018 08:08 PM, Matthew R. Trower wrote: >> Jon Trulson <j...@radscan.com> writes: >> >>> Should I expect a patch from someone for this? >>> -jon >> >> I'll send one in. While I'm at it, tell me this - would you prefer to >> keep detection logic, using system strcasestr where we think it is >> probably available, or just use our custom strcasestr on all platforms? >> > > I thought this was just for the removal of the erroneous "static" > label in the class definition...
Well, I originally sent you two patches. You applied the specific rather than general one, because of exactly this problem. Turns out it was a problem on Sun as well. My question was revisiting that. > For detection - I think it should stay. > > I think it is reasonable to assume that an OS supporting it will do it > efficiently and properly in most circumstances, something that usually > cannot be said for the home-grown versions of various things in CDE :) Eh, the implementation looks pretty standard to me. The thing is, the detection code doesn't actually detect anything --- just defines it for some platforms and not others. That's why we're in this situation to begin with. Autotools will take care of that, I suppose, for a (hopefully small) compile-time penalty. -mrt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
