On Fri, 19 Jun 2015, Douglas Carmichael wrote:
To whom it may concern:
Attached is a small patch to not define USE_MEMCPY in libDtTerm on OpenBSD 5.7.
This is a workaround for the dtterm coredumps mentioned in ticket #50.
—Douglas
Hi, a couple of things:
I'm wondering if instead of memcpy, memmove should be used in these
places. Have you tried replacing these memcpy's with memmove instead?
But as I look closer -
Another thing I notice, is that in the memcpy case, the number of
bytes to copy is the (length * sizeof(TermLine)), whereas in the
non-memcpy cases it is simply the length. This seems not quite right,
and unless I'm missing something obvious, these cases do not copy the
same number of bytes, which should be a red flag right there.
It is not clear off-hand which is correct - your change just seems to
hide the problem. I suspect that perhaps the '* sizeof(TermLine)'
might not be correct in the memcpy case, since TermLine is a pointer
and sizeof(TermLine) will be either 4 bytes in the 32b arch case or 8
bytes in the 64b arch case. Investigation is needed.
I guess what I'm saying is there is something more going on here, and
I'd rather the actual problem be understood and solved rather than
bandaged over.
Anybody have thoughts on this?
Also: For some reason, your OSX mailer marks patch file attachments as
binary/octet-stream attachments, which means that it is not possible to view
the patch in a mail viewer - it must be saved to a file first and
then viewed with a text editor, which is a PITA. Could you fix that?
--
Jon Trulson
"If we can hit that bull's-eye, the rest of the dominoes will fall
like a house of cards... Checkmate."
-- Zapp Brannigan------------------------------------------------------------------------------
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
