Sorry for breaking this one. It didn't strike me as an issue because the
va_copy macro is defined in C99 and has been supported by GCC for quite a
while, so I thought we could easily rely on that one instead of using the GNU
extension __va_copy. We could also add an #ifdef for __va_copy as a more
granular solution.
Cheers,
Jelle
-----Original Message-----
From: Ulrich Wilkens <m...@uwilkens.de>
Date: Wed, 17 Oct 2012 01:39:52
To: <cdesktopenv-devel@lists.sourceforge.net>
Subject: Re: [cdesktopenv-devel] [PATCH] Fix dtappbuilder on Linux
On 10/17/12 00:42, Marcin Cieslak wrote:
>> One of the latest NetBSD patches have broken dtappbuilder on Linux.
>> This fixes it again.
>
> Could this depend on the compiler version?
Could be. I'm testing on Xubuntu 12.04 and there the va_copy macros are
defined in /usr/lib/gcc/i686-linux-gnu/4.6/include/stdarg.h
respectively /usr/lib/gcc/x86_64-linux-gnu/4.6/include/stdarg.h:
#if !defined(__STRICT_ANSI__) || __STDC_VERSION__ + 0 >= 199900L ||
defined(__GXX_EXPERIMENTAL_CXX0X__)
#define va_copy(d,s) __builtin_va_copy(d,s)
#endif
#define __va_copy(d,s) __builtin_va_copy(d,s)
You can see that __va_copy is always defined whereas va_copy depends on
other conditions which are not fulfilled obviously.
The patch just reverts to the old dtappbuilder code for Linux and that
code used __va_copy.
--
Ulrich Wilkens
Email: m...@uwilkens.de
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
