On 21 Apr 2012, at 13:30, Bill Moseley wrote: > The code above looks like it was trying to fix some flow problems (populating > the attribute directly as a hash, for example), so the real fix is probably > something else. Perhaps a builder on body_parameters so that it isn't > populated every call. > > This look like a bug?
Yes, it does. Your proposed solution sounds entirely reasonable also. > Or should I not be adding method modifiers to prepare_body_parameters? > > BTW -- the reason I used "after prepare_body_parameters" is so that > $c->req->parameters ends up with any changes I make to the body_parameters. Yeah, I think it's perfectly reasonable usage, and we should fix it to only be called once - even if only for efficiencies sake. Could we start with some failing tests for your use-case? Thanks in advance! Cheers Tomas _______________________________________________ List: [email protected] Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/[email protected]/ Dev site: http://dev.catalyst.perl.org/
