Hi CAS authors, can you please have a look at this? I think this is a 
regular bug in the code.

On Friday, 11 September 2020 at 13:43:36 UTC+2 Petr Bodnár wrote:

> Hi,
>
> this is the source code of 
> org.apereo.cas.web.support.InvalidCookieException (v6.2.2):
>
> public class InvalidCookieException extends RootCasException {
>     private static final long serialVersionUID = -994393142011101111L;
>
>     public InvalidCookieException(final String message) {
>         super(message);
>     }
> }
>
> As you can see, the constructor expects that it is passing "message" to 
> the parent constructor. But in fact, it is passing in "code".
>
> This has the negative effect of when the exception is logged in the 
> CookieRetrievingCookieGenerator like this:
>
> LOGGER.warn(e.getMessage());
>
> ... *you will see just "null" as the logged message*. Also, unlike 
> various other exception classes, this one doesn't define its "code", not 
> sure if this is not correct as well...
>
> BTW I think this error might have arisen from the fact that 
> RootCasException uses @RequiredArgsConstructor instead of simply declaring 
> the one-parametric constructor explicitly. Something to contemplate about 
> as well?
>
> Can you please have a look at this? It seems like it shouldn't be hard to 
> fix.
>

-- 
- Website: https://apereo.github.io/cas
- Gitter Chatroom: https://gitter.im/apereo/cas
- List Guidelines: https://goo.gl/1VRrw7
- Contributions: https://goo.gl/mh7qDG
--- 
You received this message because you are subscribed to the Google Groups "CAS 
Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/apereo.org/d/msgid/cas-user/a7e4beff-0a36-4d12-876b-23f7d16b1b37n%40apereo.org.

Reply via email to