Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> index 1e31008..998bd73 100644
> --- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> +++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> @@ -552,12 +552,16 @@ class Submit:
> releases = data[pkg][submitted].keys()
> for release in data[pkg][submitted]:
> architectures = data[pkg][submitted][release].keys()
> - triggers = submitted[submitted.find(";triggers_") + 1 :]
> - triggers = triggers[: triggers.find(";")]
> - triggers = triggers[
> - triggers.find("[") + 1 : triggers.find("]")
> - ]
> - triggers = triggers.replace("'", "").split(", ")
> + triggers = []
> + if submitted.find(";triggers_") != -1:
> + triggers = submitted[
> + submitted.find(";triggers_") + 1 :
> + ]
> + triggers = triggers[: triggers.find(";")]
> + triggers = triggers[
> + triggers.find("[") + 1 : triggers.find("]")
> + ]
> + triggers = triggers.replace("'", "").split(", ")
Not a real review. This manual parsing is painful and brittle: it relies on
whatever-provides-that-data to not change anything, not even whitespaces,
otherwise this will break. In which format is that? Can't we use a proper
parser?
> if (
> req_arch in architectures
> and req_series in releases
--
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/447886
Your team Canonical's Ubuntu QA is requested to review the proposed merge of
~andersson123/autopkgtest-cloud:fix_traceback into autopkgtest-cloud:master.
--
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to : canonical-ubuntu-qa@lists.launchpad.net
Unsubscribe : https://launchpad.net/~canonical-ubuntu-qa
More help : https://help.launchpad.net/ListHelp
