I missed the 1.8.0 tag but that okay. I've pushed the change up to master now. Hopefully no more "tabs" will make it into the Android repo.
Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jun 5, 2012 at 10:41 AM, Joe Bowser <bows...@gmail.com> wrote: > I'm cool with it getting in before 1.8. > > On Tue, Jun 5, 2012 at 6:58 AM, Simon MacDonald > <simon.macdon...@gmail.com>wrote: > > > I used a plugin in Eclipse to change all the tabs to 4 spaces in the > > Cordova Android project. I pushed the commit up to this branch: > > > > > > > https://github.com/macdonst/cordova-android/commit/6d1e0356ac65db16ea8a0b4e3141640159ce6ac5 > > > > I've run mobile-spec against it and it looks to be just fine. Let me know > > if you want this pushed in before we cut 1.8.0. > > > > Simon Mac Donald > > http://hi.im/simonmacdonald > > > > > > On Mon, Jun 4, 2012 at 5:12 PM, Anis KADRI <anis.ka...@gmail.com> wrote: > > > > > I usually use VIM to retab files modified with Eclipse ;-) > > > > > > On Mon, Jun 4, 2012 at 1:55 PM, Joe Bowser <bows...@gmail.com> wrote: > > > > Hey > > > > > > > > I'm trying to do merge commits on CordovaWebView to keep it up to > date, > > > and > > > > I'm noticing that we're still modifying sections of code that still > > have > > > > tabs in it. Does Eclipse have an equivalent of the vim command > :retab? > > > > This makes trying to read the changes in the code far more difficult > > > since > > > > I have no clue what is going on. When we work on files, can we be > sure > > > to > > > > delete the tabs out and replace them with spaces? > > > > > > > > Only you can prevent nasty merges! > > > > > > > > Joe > > > > > >
