Radoslav Kolev wrote in
<CAPZ8gQtdO=hdkezT2hv6RxqGBUJpLCN3uL00s=rrokg-u2h...@mail.gmail.com>:
|Please, when you have the time provide some feedback about this patchset
|and if some changes are needed to be applied upstream:
|https://lists.busybox.net/pipermail/busybox/2025-April/091431.html
|
|Thank you!
|
|On Tue, Apr 15, 2025 at 11:33 AM Radoslav Kolev <[email protected]>
|wrote:
|
|> For a long time Linux has supported using dgram sockets
|> to avoid requiring root privileges or a setuid ping binary.
|> This patch is inspired by a patch Alpine linux carries
|> (
|> https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/busybox/\
|> 0015-ping-make-ping-work-without-root-privileges.patch
|> )
|> but with a number of improvements:
is that line
+ if (c >= 76 || using_dgram && (c == 64)) {
properly parenthesized then?
(Why doesn't the compiler scream for .. nine years?)
|> * The rootless option is configurable, and disabled by default, so no
|> concerns about size increase for those that don't want/need it
|> * The original patch only works if the fancy output option is enabled
|> * With fancy option enabled, it always returned 42 as the ttl value
|> for ipv4
|>
|> I'm currently doing some more test, but so far it seems to work well
|> for me. Any comments/suggestions/testing is welcome.
|>
|> Best regards,
|> Radoslav
|>
|> Radoslav Kolev (2):
|> Add optional rootless ping support
|> Add using_dgram as member of globals struct
|>
|> networking/ping.c | 346 +++++++++++++++++++++++++++++++++-------------
|> 1 file changed, 253 insertions(+), 93 deletions(-)
|>
|> --
|> 2.47.1
|>
|>
|Hello!
(btw i (who has nothing to say here, mind you) *think* this list
does not like HTML aka alternative parts.)
--steffen
|
|Der Kragenbaer, The moon bear,
|der holt sich munter he cheerfully and one by one
|einen nach dem anderen runter wa.ks himself off
|(By Robert Gernhardt)
|
|During summer's humble, here's David Leonard's grumble
|
|The black bear, The black bear,
|blithely holds his own holds himself at leisure
|beating it, up and down tossing over his ups and downs with pleasure
|
|Farewell, dear collar bear
_______________________________________________
busybox mailing list
[email protected]
https://lists.busybox.net/mailman/listinfo/busybox
