Hi Denys, A gentle reminder that when you're available, can you take a look at this?
Have a great day, Matthew Chae ________________________________ From: Matthew Chae <[email protected]> Sent: Friday, November 10, 2023 4:22 PM To: Denys Vlasenko <[email protected]> Cc: [email protected] <[email protected]>; Christopher Wong <[email protected]> Subject: Re: fix large PID overflow their column in top command Hi Denys, I'm sending the patch what I've mentioned. Can you take a look at this? If I don't understand correctly what you said before, let me know. Have a nice weekend, Matthew Chae ________________________________ From: busybox <[email protected]> on behalf of Matthew Chae <[email protected]> Sent: Wednesday, November 8, 2023 5:33 PM To: Denys Vlasenko <[email protected]> Cc: [email protected] <[email protected]>; Christopher Wong <[email protected]> Subject: Re: fix large PID overflow their column in top command Hi Denys, Ok. Good to hear. If I understand correctly, will you first review my patch and then give me Morris's account to commit the change? Then, let me send a patch soon. Br-Matthew ________________________________ From: Denys Vlasenko <[email protected]> Sent: Wednesday, November 8, 2023 12:35 PM To: Matthew Chae <[email protected]> Cc: [email protected] <[email protected]>; Christopher Wong <[email protected]> Subject: Re: fix large PID overflow their column in top command On Wed, Nov 1, 2023 at 10:18 AM Matthew Chae <[email protected]> wrote: > > Hi maintainer, > > I'd like to hear your opinion regarding large PID can overflow its column in > top command. > > The max PID value can have 7 digits as the 4194304. > Busybox v1.36 released a new patch to handle large PID value in top command. > However, it still causes misalignment between the title and the number for 7 > digits or 6 digits PID. > The presence of a large number of PID and PPID digits in the column may cause > overflow, making it impossible to display the entire data accurately. > Plus, the large PID causes that user name can't be displayed up to 8 > characters and result in the truncation of less than 8 characters. > > I can contribute new patch which allocates appropriate space for the number > of digits in the PID and PPID to represent the values in each column > correctly. > This can make alignment between the title and the number for 7 digits PID and > 5 digits PID and also display user name up to 8 characters. > > What do you think? If you agree, I will send a patch. Absolutely, please send a patch. Would be interesting to see a good solution.
_______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
