The GitHub Actions job "CI" on kvrocks.git has succeeded.
Run started by GitHub user git-hulk (triggered by git-hulk).

Head commit for run:
4ecb35b9c11a6b2cd961222bbf7a17d4d79cc8a3 / hulk <hulk.webs...@gmail.com>
Fix should use the minimum compatible RDB version when dumping the payload 
(#2252)

Currently, we're using the maximum RDB version(12) when dumping the payload 
which is not allowed in the old Redis versions(before Redis 7), so it will 
throw the error:

```
127.0.0.1:6379> RESTORE a 0 "\x00\xc0{\x0c\x00\x83\x94g!\xfaP\xf9\xf0"
(error) ERR DUMP payload version or checksum are wrong
```

This PR changes the payload's RDB version to 6 to make it work with the old 
Redis versions. And after applying this PR, it works well in Redis 4/6:

```
127.0.0.1:6379> RESTORE a 0 "\x00\xc0{\x06\x00\xde\x0f;a\xf5/[*"
OK
127.0.0.1:6379> get a
"123"

127.0.0.1:6379> RESTORE a 0 "\x00\xc0{\x06\x00\xde\x0f;a\xf5/[*"
OK
127.0.0.1:6379> get a
"123"
```

Fixes #2251

Report URL: https://github.com/apache/kvrocks/actions/runs/8701594688

With regards,
GitHub Actions via GitBox

Reply via email to