The GitHub Actions job "CI" on kvrocks.git has failed.
Run started by GitHub user git-hulk (triggered by git-hulk).

Head commit for run:
21611f7e1b25a1f6a7c029249b88dc00033f1733 / git-hulk <hulk.webs...@gmail.com>
Use the PUSH type in PubSub output if the RESP3 was enabled

Currently, some Redis clients like lettuce and redis-cli will expect
the PUSH type while running the PubSub subscribe command. Or it will
regard the ARRAY output as a normal command output and won't wait for
the furthur messages.

Before applying this patch, redis-cli will return immediately if RESP3
was enabled:

```shell
❯ redis-cli -3 -p 6666
127.0.0.1:6666> SUBSCRIBE channel
1) "subscribe"
2) "channel"
3) (integer) 1
```

After applying, it will wait for the further messages:

```
❯ redis-cli -3 -p 6666
127.0.0.1:6666> SUBSCRIBE channel
1) "subscribe"
2) "channel"
3) (integer) 1

Reading messages... (press Ctrl-C to quit or any key to type command)
```

Report URL: https://github.com/apache/kvrocks/actions/runs/8247555741

With regards,
GitHub Actions via GitBox

Reply via email to