The GitHub Actions job "CI" on kvrocks.git has failed. Run started by GitHub user enjoy-binbin (triggered by enjoy-binbin).
Head commit for run: f9fc3402d8a6d012d92ca90ca9854654e509bcf1 / Binbin <binloveplay1...@qq.com> Update error message and add the ERR error code (#1597) We now have some error messages that do not return an ERR error code: ``` 127.0.0.1:6666> cluster nodes Cluster mode is not enabled ``` As far as i know this doesn't affect the client libs, and doesn't affect the users. But I think it's right to add the error code. Note that Redis will actually count error messages and standardize the error codes, like: ``` 127.0.0.1:6379> info Errorstats # Errorstats errorstat_ERR:count=2 errorstat_EXECABORT:count=1 errorstat_WRONGTYPE:count=1 ``` We mixed using the status message and error output in some places, this PR checks all redis::Error calls and use error status to replace it. (Only the ERR case is handled, others are not handled yet.) We like to have the "ERR" + some_error_message construction only in one place as an implementation detail of the Redis protocol. Maybe, inside redis::Error or so. We will leave it for a future PR as a cleanup. (pull out the error code and error message) Report URL: https://github.com/apache/kvrocks/actions/runs/5629830579 With regards, GitHub Actions via GitBox
