And really sorry about yatus vs. yetus - I am slightly dialectic and when things are not in the dictionary, I tend to do many mistakes. I hope it's not something that people can take as a sign of being "worse", but if you felt offended by that - apologies.
On Wed, Oct 14, 2020 at 4:34 PM Jarek Potiuk <jarek.pot...@polidea.com> wrote: > Hey Allen, > > I would be super happy if you could help us to do it properly at Airlfow - > would you like to work with us and get the yatus configuration that > would work for us ? I am super happy to try it? Maybe you could open PR > with some basic yatus implementation to start with and we could work > together to get it simplified? I would love to learn how to do it. > > J > > > On Wed, Oct 14, 2020 at 3:37 PM Allen Wittenauer > <a...@effectivemachines.com.invalid> wrote: > >> >> >> > On Oct 13, 2020, at 11:04 PM, Jarek Potiuk <jarek.pot...@polidea.com> >> wrote: >> > This is a logic >> > that we have to implement regardless - whether we use yatus or >> pre-commit >> > (please correct me if I am wrong). >> >> I'm not sure about yatus, but for yetus, for the most part, yes, >> one would like to need to implement custom rules in the personality to >> exactly duplicate the overly complicated and over engineered airflow >> setup. The big difference is that one wouldn't be starting from scratch. >> The difference engine is already there. The file filter is already there. >> full build vs. PR handling is already there. etc etc etc >> >> > For all others, this is not a big issue because in total all other >> > pre-commits take 2-3 minutes at best. And if we find that we need to >> > optimize it further we can simply disable the '--all-files' switch for >> > pre-commit and they will only run on the latest commit-changed files >> > (pre-commit will only run the tests related to those changed files). But >> > since they are pretty fast (except pylint/mypy/flake8) we think running >> > them all, for now, is not a problem. >> >> That's what everyone thinks until they start aggregating the time >> across all changes... >> >> > > -- > > Jarek Potiuk > Polidea <https://www.polidea.com/> | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > [image: Polidea] <https://www.polidea.com/> > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
