Michał's investigation came up with 2 features that only GHPRB seems to have: 1. DSL configuration 2. Phrase hooks (being able to comment on a PR to trigger specific tests (=Jenkins jobs)).
On 2019/07/11 08:40:14, Michał Walenia <michal.wale...@polidea.com> wrote: > Hi, could you tell us which plugin do you plan to use as a replacement for > GHPRB? > I'd also like to investigate how to migrate Beam's Jenkins jobs to use it. > > Thanks, > Michal > > On Thu, Jul 11, 2019 at 9:21 AM Daniel Gruno <humbed...@apache.org> wrote: > > > As there has been quite a bit of unforeseen trouble here, we have added > > the old plugin back in, while we evaluate how to best switch (or whether to > > stick with the GHPRB instead). Needless to say, there is some conflicting > > documentation we need to look at one more time. > > > > On 2019/07/11 03:14:17, Ismael Juma <ism...@juma.me.uk> wrote: > > > Hi, > > > > > > A couple more issues: > > > > > > 1. If you configure multiple Jenkins jobs (eg one for Java 8 and one for > > > Java 11), only 1 seems to update the commit status in the PR. The > > previous > > > plugin was able to show the status for multiple jobs. > > > 2. It's unclear how to enable a job for certain branches only. With the > > > previous plugin, we could configure the Java 11 job to only trigger for > > the > > > branches where Java 11 is supported. > > > > > > Am I missing something or is the "modern" plugin not a suitable > > > replacement? Would you consider restoring the previous plugin? > > > > > > Thanks, > > > Ismael > > > > > > On Wed, Jul 10, 2019 at 7:40 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > Does this "modern" version provide a way to retest builds without > > pushing > > > > additional commits? This is very useful when tests fail due to > > > > environmental issues or if they're flaky. I can't seem to find mention > > of > > > > it in the documentation. It would be a shame to lose this feature. > > > > > > > > Ismael > > > > > > > > On Wed, Jul 10, 2019 at 7:30 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > >> Looks like it has. Apache Kafka PRs don't trigger Jenkins builds any > > > >> longer. :( I hope the conversion is smooth, will try it now. > > > >> > > > >> Ismael > > > >> > > > >> On Wed, Jul 10, 2019 at 3:33 PM Kenneth Knowles <k...@apache.org> > > wrote: > > > >> > > > >>> Has this support already been removed? > > > >>> > > > >>> All of Beam's jobs use this plugin. They are generated using the job > > DSL, > > > >>> but we have not ported to the other plugin. > > > >>> > > > >>> Kenn > > > >>> > > > >>> On Wed, Jul 10, 2019 at 1:33 PM Daniel Gruno <humbed...@apache.org> > > > >>> wrote: > > > >>> > > > >>> > Hi folks, > > > >>> > as part of some cleanup and consolidation (essentially we don't > > want to > > > >>> > maintain two different plugins that do the same thing), we have > > removed > > > >>> > support for the old GitHub PR Builder on Jenkins, and are focusing > > on > > > >>> the > > > >>> > modern variant. If your build previously made use of the old one > > (It's > > > >>> > called "GitHub Pull Request Builder" in the job configuration), we > > ask > > > >>> that > > > >>> > you please switch to the newer one (called "Build pull requests to > > the > > > >>> > repository" in the same config). There should be no other changes, > > but > > > >>> if > > > >>> > your builds start acting up, do let infra know :). > > > >>> > > > > >>> > As an added bonus, you no longer need to contact infra about > > webhooks > > > >>> when > > > >>> > setting up PR builds for new repositories, it should just work(tm). > > > >>> > > > > >>> > With regards, > > > >>> > Daniel on behalf of ASF Infra. > > > >>> > > > > >>> > > > >> > > > > > > > > -- > > Michał Walenia > Polidea <https://www.polidea.com/> | Software Engineer > > M: +48 791 432 002 <+48791432002> > E: michal.wale...@polidea.com > > Unique Tech > Check out our projects! <https://www.polidea.com/our-work> >
