On 2019/01/09 21:36:50, "Elek, Marton" <e...@apache.org> wrote:
>
>
> On 1/8/19 12:16 PM, Steve Loughran wrote:
>
> > One thing which Spark does is to have
> >
> > * a list of people who are trusted enough to have their PRs auto tested on
> > some UCB infra. I think you get on that list once you have 1+ PR actually
> > accepted
> > * a list of people who have the right to kick off a test by asking for it
> > on the PR https://github.com/apache/spark/pull/21286#issuecomment-388096882
> >
>
> Kubernetes uses a similar approach:
>
> The following is added to a new PR as a comment by the k8s-ci-bot:
>
> ```
> I'm waiting for a kubernetes member to verify that this patch is
> reasonable to test. If it is, they should reply with /ok-to-test on its
> own line. Until that is done, I will not automatically test new commits
> in this PR, but the usual testing commands by org members will still
> work. Regular contributors should join the org to skip this step.
>
> Once the patch is verified, the new status will be reflected by the
> ok-to-test label.
>
> I understand the commands that are listed here.
>
> ```
>
> one example:
> https://github.com/kubernetes/kubernetes/pull/71468#issuecomment-442133030
>
And then once you get the /ok-to-test does that apply to all commits after?
Because if it does then I just push something innocuous, wait for the
/ok-to-test and then push the exploit immediately after... as soon as the
exploit build starts I just force push back to the original ref making tracing
the whole thing a lot harder!
>
> Marton
>
