Hi,

the buildbot master currently ignores most commits on the subversion
1.6.x branch. The reason is that the function detecting if a commit is
important enough - that I provided during the migration - is faulty.

Attached is a patch to fix this issue, can anyone of the buildbot
maintainers apply this?

Note: can't test the patch here, so a review is welcome.

Lieven
Index: subversion.conf
===================================================================
--- subversion.conf     (revision 775282)
+++ subversion.conf     (working copy)
@@ -11,16 +11,17 @@ excludes = masterExcludes + ["COMMITTERS", "STATUS
             "BUGS", "www", "notes", "packages", "subversion/LICENSE", 
"subversion/po", "doc", "contrib",
             "tools", "dist.sh"]
 
+# The change is not important when all of the files are in the excludes list.
 def isSubversionImportant(change):
     if not excludes:
         return True
 
     for file in change.files:
-        triggerBuild = False
+        triggerBuild = True
         for pattern in excludes:
             match = re.match(pattern, file)
-            if not match:
-                triggerBuild = True
+            if match:
+                triggerBuild = False
                 break
         if triggerBuild:
             return True

Reply via email to