On Fri, 8 May 2026 17:39:39 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> consistent libdirs, not libdir, as can be a list. Use
>> jdk.internal.util.OperatingSystem for OS check.
>
> src/jdk.attach/share/classes/sun/tools/attach/VirtualMachineCoreDumpImpl.java
> line 103:
>
>> 101: throw new IOException("Not a MiniDump: '" +
>> filename + "'");
>> 102: }
>> 103: } else if (OperatingSystem.isLinux()) {
>
> I think it would be good to see if this could be refactored into linux and
> windows specific code.
(this is now split up, e.g.
src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineCoreDumpImpl.java)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4271646578
