On Tue, 29 Sep 2026 16:15:00 GMT, Jaikiran Pai <[email protected]> wrote:

>> Can I please get a review of this trivial change which proposes to prevent 
>> the deprecation warning from `SourcePositions.getStartPosition()` usage?
>> 
>> JDK 27, through https://bugs.openjdk.org/browse/JDK-8380147, deprecated the 
>> `SourcePositions.getStartPosition(CompilationUnitTree file, Tree tree)` API. 
>> The deprecation note suggests using `SourcePositions.getStartPosition(Tree 
>> tree)`, which is what this commit does.
>> 
>> I've verified locally that with this change the deprecation warning is no 
>> longer emitted and the build continues to complete normally.
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jaikiran Pai has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - merge latest from master branch
>  - 8392839: Deprecation warning for SourcePositions.getStartPosition() usage 
> when building the JDK

Thank you Chen and Jan for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33002#issuecomment-6011038609

Reply via email to