On Tue, 25 Aug 2026 08:52:19 GMT, Amit Kumar <[email protected]> wrote:
>> Harshit Dhiman has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review comments > > src/hotspot/cpu/s390/gc/z/zBarrierSetAssembler_s390.cpp line 516: > >> 514: const Register zpointer = Z_R1; >> 515: Label done, loop, load_bad, load_good, store_bad, store_good; >> 516: __ z_slag(Z_R0, Z_ARG3, 3); > > should we zero-extend Z_ARG3 here ? because I am not sure if there exist a > guarantee that upper half will be zero or not. @offamitkumar Should I add `assert_positive_int` here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3910986113
