On Fri, 27 Feb 2026 00:27:08 GMT, Alexey Semenyuk <[email protected]> wrote:

> For runtime bundling, jpackage will read the version for the output bundle 
> from the value of the "JAVA_VERSION" property of JDK's "release" file if the 
> `--app-version` option is not on the command line. jpackage will normalize 
> the version it reads from the "release" file to fit into the constraints of 
> the bundle it produces.
> 
> If the "release" file doesn't exist, is malformed, or the value of the 
> "JAVA_VERSION" property is invalid, jpackage will ignore it.
> 
> If the value of the `--runtime-image` option references a valid macOS bundle, 
> not a plain directory, jpackage will ignore the "release" file and will 
> attempt to read the version from the "Info.plist" file of the input bundle.
> 
> Revamed AppVersionTest and updated it to cover the new functionality.
> 
> Based on https://github.com/openjdk/jdk/pull/29260 PR.

Looks good with minor comment.

test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/model/DottedVersionTest.java
 line 203:

> 201:     }
> 202: 
> 203:     private static Stream<Arguments> testPadNegative() {

Looks like `testPadNegative` is not used.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29948#pullrequestreview-3926392124
PR Review Comment: https://git.openjdk.org/jdk/pull/29948#discussion_r2915397135

Reply via email to