On Fri, 27 Feb 2026 09:12:02 GMT, Matthias Baesken <[email protected]> wrote:
> We run into compile errors on AIX : > > > /priv/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/src/java.base/share/native/libzip/zlib/zconf.h:470:5: > error: 'HAVE_UNISTD_H' is not defined, evaluates to 0 [-Werror,-Wundef] > 470 | #if HAVE_UNISTD_H-0 /* may be set to #if 1 by ./configure */ > | ^ > /priv/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/src/java.base/share/native/libzip/zlib/zconf.h:474:5: > error: 'HAVE_STDARG_H' is not defined, evaluates to 0 [-Werror,-Wundef] > 474 | #if HAVE_STDARG_H-0 /* may be set to #if 1 by ./configure */ > | ^ > 2 errors generated. make/autoconf/lib-bundled.m4 line 270: > 268: if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then > 269: LIBZ_CFLAGS="$LIBZ_CFLAGS > -I$TOPDIR/src/java.base/share/native/libzip/zlib" > 270: if test "x$OPENJDK_TARGET_OS" = xmacosx || test > "x$OPENJDK_TARGET_OS" = xaix; then Hello Matthias, to be consistent with the rest of this file, I think we should use `-o` here instead of `||`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29953#discussion_r2863384979
