On Thu, 26 Feb 2026 07:47:35 GMT, SendaoYan <[email protected]> wrote:
>> Hi all, >> >> clang23+gcc12(ubuntu) generate compiler warning >> "get_temporary_buffer<testing::TestInfo *>' is deprecated >> [-Werror,-Wdeprecated-declarations]". And this compiler warning from >> googletest file googletest/src/gtest.cc, googletest/src/gtest.cc invoke >> `std::stable_sort`, and `std::stable_sort` invoke deprecated >> `std::get_temporary_buffer`. So this warning is unrelated to JDK totally. >> >> This PR disable deprecated-declarations warning when building libgtest. >> Change has been verified locally. > > SendaoYan has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Merge branch 'openjdk:master' into jbs8378684 > - Disable deprecated-declarations only for gtest-all.cc > - 8378684: Fix -Wdeprecated-declarations warnings from gtest by clang23 Looks good to me, but please wait for Kim to approve too. ------------- Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29919#pullrequestreview-3862467278
