On Wed, 25 Feb 2026 13:28:03 GMT, Alan Bateman <[email protected]> wrote:
> @jaikiran No changes from upstream, right? (ignoring the make file update to > compile with -DHAVE_STDARG_H=1). That's correct - no changes compared to upstream other than the make file change. The trivial make file changes, in our JDK build, were necessitated due to a change in the upstream code which now relies on these macro values to be 1 for it to include certain functionality from zlib https://github.com/madler/zlib/commit/7108497fda9d4536a1afade7f42266e06dca4488 > Also would be possible to update the PR description to say what testing has > been done as the defaults only use the in-tree version on Windows. I was planning to add that detail when I opened the PR, but I hesitated a bit. I have tested tier1, tier2, tier3 on all platforms in our CI and they all passed fine. But that testing was done a few days back, so I didn't include that detail and instead triggered a new run. I should have the results soon and I'll update here once I have them. > as the defaults only use the in-tree version on Windows. The in-tree version also gets used on macosx-aarch64. We were forced to do that because of an extremely hard to debug intermittent failures in zlib that was shipped in macos. Details in https://bugs.openjdk.org/browse/JDK-8286623. So right now, even macosx-aarch64 uses bundled https://github.com/openjdk/jdk/blob/master/make/autoconf/lib-bundled.m4#L219. The original issue that we reported to Apple https://bugs.openjdk.org/browse/JDK-8282954 has reportedly been addressed in macosx 13.x and higher, but we haven't yet decided if we want to go back to that using "system" on that platform. I also plan to run higher tier tests before integrating. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29916#issuecomment-3959366274
