On Wed, 22 Oct 2025 22:47:34 GMT, Erik Joelsson <[email protected]> wrote:

>> OK, I believe I understand what you're saying. Do you know where the place 
>> is where the JDK_IMAGE_DIR is created and renaming/filtering of the pdb 
>> files would need to happen?
>
>> OK, I believe I understand what you're saying. Do you know where the place 
>> is where the JDK_IMAGE_DIR is created and renaming/filtering of the pdb 
>> files would need to happen?
> 
> So the change would be to _not_ copy debug symbols to the `JDK_IMAGE_DIR` 
> when `--with-external-symbols-in-bundles=public` is set. I think this would 
> be the line you need to put conditions around: 
> https://github.com/openjdk/jdk/blob/be18e7ecfd2e89a0abb168e0d9a5b69598e2199f/make/Images.gmk#L307

OK, finally I have updated my PR to implement the suggestions of @erikj79. Now 
the exploded image during the build will only contain the full pdb files and in 
the actual JDK and JRE images, we'll have the stripped pdb files (as well as in 
the jmods), if the option is set. And this also propagates to bundles. The 
debug image/debug bundle will of course only have the full symbol files.

I also update the test 
test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java to expect 
debug symbols in case configure option `--with-external-symbols-in-bundles` is 
non-empty. This also contains some updates to the Whitebox functionality for 
checking which kind of debug symbols should be delivered and cleanup of test 
test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java which was 
modified already with 
[JDK-8370064](https://bugs.openjdk.org/browse/JDK-8370064).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24012#issuecomment-3595830306

Reply via email to